fix(richdocuments): Use filename from DownloadAs postmessage for correct file extension#16623
fix(richdocuments): Use filename from DownloadAs postmessage for correct file extension#16623Rash419 wants to merge 2 commits intonextcloud:masterfrom
Conversation
…ect file extension Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
|
|
||
| else -> { | ||
| val downloadFileName = downloadJson.optString(FILENAME, fileName) | ||
| downloadFile(url, downloadFileName) |
There was a problem hiding this comment.
Hi, thank you for the PR.
I have a quick question regarding the fileName handling. Is the fileName always incorrect, or is it only missing the extension in some cases? Also, can we confirm whether downloadJson.optString(FILENAME, fileName) consistently returns valid data?
Could you please share the steps to reproduce the issue and how you tested this? That would help us better understand the scenario and verify the behavior on our side.
There was a problem hiding this comment.
Hi,
fileName extension is incorrect when using "Download as" button to download file into different format. In Collabora Online side, I added CollaboraOnline/online#14344 filename property to the DownloadAs postmessage JSON which will filename with correct extension.
Steps to reproduce:
- Open writer document
- Hamburger Menu > Download as -> rtf
- File will have wrong extension on download
3 participants
🖼️ Screenshots
🏁 Checklist